fix: validate proof state before accepting level completion#455
Open
Ocean-Moist wants to merge 1 commit intoleanprover-community:mainfrom
Open
fix: validate proof state before accepting level completion#455Ocean-Moist wants to merge 1 commit intoleanprover-community:mainfrom
Ocean-Moist wants to merge 1 commit intoleanprover-community:mainfrom
Conversation
The server sets `completed` based on absence of diagnostics, not goal state. During fast typing, diagnostics are transiently empty while the server is still processing, causing false completion. Validate that the last proof step has actual tactic info (column != null) and that the initial step has goals before accepting completion client-side. Fixes leanprover-community#453
|
I also had this problem locally, and I think you need to add a guard at line 450 of |
khwilson
added a commit
to khwilson/lean4game
that referenced
this pull request
Mar 9, 2026
Basically this commit on `main` leanprover-community#455 With one extra guard added in info.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completedbased on absence of diagnostics, not goal state. During fast typing, diagnostics are transiently empty while the server is still processing, causing false completion.column != null) and that the initial step has goals before accepting completion client-side.Fixes #453, fixes #402
Test plan