feat(AlgbraicGeometry), Hom(-, X) commutes with inverse limits for schemes of finite presentation#30985
feat(AlgbraicGeometry), Hom(-, X) commutes with inverse limits for schemes of finite presentation#30985erdOne wants to merge 22 commits intoleanprover-community:masterfrom
Hom(-, X) commutes with inverse limits for schemes of finite presentation#30985Conversation
PR summary cb53e58ea4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request has conflicts, please merge |
|
This PR/issue depends on: |
…lib4 into erd1/ega48-more
…into erd1/ega48-more
|
I was trying to review this but got very confused until I finally scrolled to the top of the file and saw the comment "We refrain from considering diagrams in the over category since inverse limits in the over category is isomorphic to limits in Is this really a good idea? Why not just consider cones in the over category and provide proper API to move back and forth between limits in In any case, don't you want to prove the result in the PR title, i.e. a result of the form |
I wasn't sure at first, but since throughout the development I have never once hoped that I had a cone in
Yes. It will come as a follow up. I don't expect it will be useful at all though. It is merely an aesthetically pleasing thing to have.
I'd say the injectivity is harder but it is already done earlier in the file.
Sure I'll try to add some docstrings. |
chrisflav
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
Co-authored-by: Christian Merten <[email protected]>
|
Thanks! bors merge |
…schemes of finite presentation (#30985)
|
Build failed (retrying...): |
…schemes of finite presentation (#30985)
|
Build failed: |
…lib4 into erd1/ega48-more
…into erd1/ega48-more
|
There are still a couple of errors, can you fix them? Thanks! bors d+ |
|
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
|
This pull request has conflicts, please merge |
Uh oh!
There was an error while loading. Please reload this page.