Skip to content

feat(AlgbraicGeometry), Hom(-, X) commutes with inverse limits for schemes of finite presentation#30985

Open
erdOne wants to merge 22 commits intoleanprover-community:masterfrom
erdOne:erd1/ega48-more
Open

feat(AlgbraicGeometry), Hom(-, X) commutes with inverse limits for schemes of finite presentation#30985
erdOne wants to merge 22 commits intoleanprover-community:masterfrom
erdOne:erd1/ega48-more

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Oct 27, 2025

@github-actions github-actions bot added large-import Automatically added label for PRs with a significant increase in transitive imports t-algebraic-geometry Algebraic geometry labels Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

PR summary cb53e58ea4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Opens.IsBasis.isOpenCover
+ Opens.IsBasis.isOpenCover_mem_and_le
+ Scheme.exists_π_app_comp_eq_of_locallyOfFinitePresentation
+ Scheme.exists_π_app_comp_eq_of_locallyOfFinitePresentation_of_isAffine
+ wideCospan
+ wideSpan

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 28, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 15, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Dec 15, 2025
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 20, 2026
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 21, 2026
@dagurtomas
Copy link
Contributor

I was trying to review this but got very confused until I finally scrolled to the top of the file and saw the comment "We refrain from considering diagrams in the over category since inverse limits in the over category is isomorphic to limits in Scheme. Instead we use D ⟶ (Functor.const I).obj S to say that the diagram is over the base scheme S".

Is this really a good idea? Why not just consider cones in the over category and provide proper API to move back and forth between limits in Scheme and limits in the over category?

In any case, don't you want to prove the result in the PR title, i.e. a result of the form PreservesLimit _ (yoneda.obj _)? Currently, your statement is only surjectivity of the comparison map (which is indeed the hard part). Also, it wouldn't hurt to add some documentation to these long proofs, and preferably split them up further.

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 29, 2026
@erdOne
Copy link
Member Author

erdOne commented Jan 29, 2026

Is this really a good idea? Why not just consider cones in the over category and provide proper API to move back and forth between limits in Scheme and limits in the over category?

I wasn't sure at first, but since throughout the development I have never once hoped that I had a cone in Over X instead, I can quite confidently say that yes this is a good idea.

In any case, don't you want to prove the result in the PR title, i.e. a result of the form PreservesLimit _ (yoneda.obj _)?

Yes. It will come as a follow up. I don't expect it will be useful at all though. It is merely an aesthetically pleasing thing to have.

Currently, your statement is only surjectivity of the comparison map (which is indeed the hard part)

I'd say the injectivity is harder but it is already done earlier in the file.

Also, it wouldn't hurt to add some documentation to these long proofs, and preferably split them up further.

Sure I'll try to add some docstrings.

@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 2, 2026
Copy link
Contributor

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 5, 2026
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 5, 2026
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 5, 2026
@joelriou
Copy link
Contributor

joelriou commented Feb 6, 2026

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 6, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 6, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 6, 2026

Build failed:

@riccardobrasca
Copy link
Member

There are still a couple of errors, can you fix them? Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 9, 2026

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 9, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 12, 2026
@mathlib-merge-conflicts
Copy link

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants