Skip to content

Conversation

@gasparattila
Copy link
Contributor

@gasparattila gasparattila commented Jan 14, 2026

This PR generalizes the completeness result of NonemptyCompacts from metric spaces to uniform spaces.


Open in Gitpod

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jan 14, 2026
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

PR summary e2a36edc3e

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.UniformSpace.Closeds 683 684 +1 (+0.15%)
Import changes for all files
Files Import difference
Mathlib.Topology.UniformSpace.Closeds 1

Declarations diff

+ _root_.TopologicalSpace.Compacts.completeSpace_iff
+ coe_eq_empty
+ coe_nonempty
+ completeSpace_iff
+ instance [CompleteSpace α] : CompleteSpace (Compacts α) := by
+ instance [CompleteSpace α] : CompleteSpace (NonemptyCompacts α)
+ isClosedEmbedding_toCompacts
+ range_toCompacts
- instCompleteSpace

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

…cts`

This PR generalizes the completeness result of `NonemptyCompacts` from metric spaces to uniform spaces.
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 16, 2026
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants