Skip to content

[Merged by Bors] - ci: add splice-bot action#33979

Closed
adomani wants to merge 5 commits intoleanprover-community:masterfrom
adomani:add_splice_bot_action
Closed

[Merged by Bors] - ci: add splice-bot action#33979
adomani wants to merge 5 commits intoleanprover-community:masterfrom
adomani:add_splice_bot_action

Conversation

@adomani
Copy link
Contributor

@adomani adomani commented Jan 14, 2026

Adds a CI action that inspects review comments.

If a review comment posted by the PR author or a member of the reviewer or maintainer teams selects at least one line and contains the string splice-bot at the start of some line, then the bot will create a branch in the new mathlib4_copy repo with just the changes to the selected file, clearing all history, and then open a new PR from that branch.

mathlib4_copy is a repo with GitHub actions disabled on it so that people cannot use SpliceBot to trigger workflows they otherwise couldn't. Reviewers and maintainers also have write permissions to mathlib4_copy so that they can make changes to the PR branches created by this bot if necessary.

See https://github.com/leanprover-community/SpliceBot


Before merging:

  • Add GitHub apps + secrets needed
  • Update workflow for new version of Splicebot (will be 2 workflow files instead of 1)
  • Mark ready for review

After merging:

  • Make sure that CI runs on the PRs created by the action.
  • Confirm that PRs generated from forks also work as expected.

Open in Gitpod

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Jan 14, 2026
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

PR summary 3c4005cb76

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen bryangingechen self-assigned this Jan 14, 2026
@bryangingechen
Copy link
Contributor

bryangingechen commented Jan 14, 2026

I will review the code in the new action at https://github.com/leanprover-community/SpliceBot and make suggestions there. Let's not merge this until I've done so.

edit: I ended up making a lot of changes to SpliceBot, so I'm no longer a suitable reviewer.

@joneugster joneugster changed the title ci: add splice-bot action feat(CI): add splice-bot action Feb 1, 2026
@joneugster joneugster changed the title feat(CI): add splice-bot action ci: add splice-bot action Feb 1, 2026
@bryangingechen bryangingechen removed their assignment Feb 12, 2026
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 12, 2026
@bryangingechen bryangingechen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 12, 2026
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 16, 2026
@bryangingechen bryangingechen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 17, 2026
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 17, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2026
Adds a CI action that inspects review comments.

If a review comment posted by the PR author or a member of the reviewer or maintainer teams selects at least one line and contains the string `splice-bot` at the start of some line, then the bot will create a branch in the new [mathlib4_copy repo](https://github.com/leanprover-community/mathlib4_copy) with just the changes to the selected file, clearing all history, and then open a new PR from that branch. 

mathlib4_copy is a repo with GitHub actions disabled on it so that people cannot use SpliceBot to trigger workflows they otherwise couldn't. Reviewers and maintainers also have write permissions to mathlib4_copy so that they can make changes to the PR branches created by this bot if necessary.

See https://github.com/leanprover-community/SpliceBot

Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci: add splice-bot action [Merged by Bors] - ci: add splice-bot action Feb 17, 2026
@mathlib-bors mathlib-bors bot closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments