Skip to content

Conversation

@b-mehta
Copy link
Contributor

@b-mehta b-mehta commented Jan 16, 2026


Open in Gitpod

@b-mehta b-mehta added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 16, 2026
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

PR summary 0bc483ae44

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eventuallyEq_of_isMinFilter_of_isMaxFilter

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label Jan 16, 2026
@ocfnash
Copy link
Contributor

ocfnash commented Jan 16, 2026

The CI failure looks spurious but I guess I'll let you diagnose

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 16, 2026
@b-mehta
Copy link
Contributor Author

b-mehta commented Jan 16, 2026

Seems to have vanished! I made a small change to the PR: adding a docstring to the lemma. I hope it's okay if I merge that!

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

This PR was included in a batch that was canceled, it will be automatically retried

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Build failed (retrying...):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants