Skip to content

Conversation

@grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 16, 2026

This PR adds support for the finiteness [h, h'] syntax. This can be combined with the existing versions, such as supporting aesop clauses or the finiteness? and finiteness_nonterminal variants. This allows golfing mathlib in a few places.

While adding tests, we take the opportunity to also test finiteness? and adding aesop clauses: these were previously untested. We also improve the tactic doc-string slightly: making it fully confirm to the new style guidelines is left for a future PR.

This PR is inspired by #30388.


Open in Gitpod

…heses

And slightly rewrite the doc-strings to conform more closely to the guidelines.
Also include tests for using aesop clauses and finiteness?.
@grunweg grunweg added the t-meta Tactics, attributes or user commands label Jan 16, 2026
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2026

@fpvandoorn We discussed this briefly. @Vierkantor in case you'd like to look at the new doc-string formatting (entirely optional --- but it would be good to land this PR before polishing finiteness' doc-string).

@github-actions
Copy link

PR summary d498a88e35

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant