feat: generalize HasCompl.compl image/preimage lemmas to Involutive#34040
Open
Ruben-VandeVelde wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat: generalize HasCompl.compl image/preimage lemmas to Involutive#34040Ruben-VandeVelde wants to merge 1 commit intoleanprover-community:masterfrom
Ruben-VandeVelde wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Contributor
Ruben-VandeVelde
commented
Jan 16, 2026
Ruben-VandeVelde
commented
PR summary 26299a5af4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
eric-wieser
reviewed
Jan 19, 2026
| theorem Involutive.image_image {f : α → α} (hf : f.Involutive) (s : Set α) : | ||
| f '' (f '' s) = s := | ||
| hf.leftInverse.image_image s | ||
|
|
Member
There was a problem hiding this comment.
Could you also add
protected theorem Involutive.image {f : α → α} (hf : Involutive f) : Involutive (image f)
eric-wieser
reviewed
Jan 19, 2026
| theorem LeftInverse.image_image {g : β → α} (h : LeftInverse g f) (s : Set α) : | ||
| g '' (f '' s) = s := by rw [← image_comp, h.comp_eq_id, image_id] | ||
|
|
||
| theorem Involutive.image_image {f : α → α} (hf : f.Involutive) (s : Set α) : |
Member
There was a problem hiding this comment.
Do we want preimage_preimage too?
eric-wieser
reviewed
Jan 19, 2026
| compl_involutive.image_image s | ||
|
|
||
| theorem preimage_compl_eq_image_compl : Compl.compl ⁻¹' s = Compl.compl '' s := | ||
| congr_fun (compl_involutive.image_eq_preimage_symm).symm s |
Member
There was a problem hiding this comment.
I think we should provide both the applied and unapplied versions for both Compl.compl and Involutive. I suppose the unapplied one can be primed.
I think a good argument for having the applied one is that it is easily loogle-able.
joneugster
added
the
awaiting-author
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
mathlib-merge-conflicts
bot
removed
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.