perf(Algebra): higher priority for Algebra.to_smulCommClass

[alreadydone]

inspired by #33908

---

[github-actions]

PR summary 95093e961c

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

+ instance (priority := high) Algebra.to_smulCommClass {R A} [CommSemiring R] [Semiring A]
- instance (priority := 200) Algebra.to_smulCommClass {R A} [CommSemiring R] [Semiring A]

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

---

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[alreadydone]

!radar

[leanprover-radar]

Benchmark results for ced4d61 against 95093e9 are in! @alreadydone

Small changes (5✅, 2🟥)

• 🟥 build/module/Mathlib.Analysis.CStarAlgebra.ApproximateUnit//instructions: +1.6G (+1.0%)
• ✅ build/module/Mathlib.Analysis.InnerProductSpace.StarOrder//instructions: -1.9G (-5.3%)
• ✅ build/module/Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.PosPart.Basic//instructions: -1.2G (-1.3%)
• ✅ build/module/Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.Rpow.Basic//instructions: -4.6G (-2.3%)
• 🟥 build/module/Mathlib.Data.Char//instructions: +248.2M (+6.7%)
• ✅ build/module/Mathlib.Lean.Meta.DiscrTree//instructions: -241.9M (-7.8%)
• ✅ build/module/Mathlib.Topology.Algebra.Module.CharacterSpace//instructions: -450.2M (-2.1%)

[alreadydone]

!radar

[leanprover-radar]

Benchmark results for 1e68751 against 95093e9 are in! @alreadydone

Notes (1🟥)

• 🟥 main exited with code 1

No significant changes detected.

[Garmelon]

I've restarted the run, it should complete without errors now. The build appears to be a bit flaky from time to time.

!bench

[leanprover-radar]

Benchmark results for 1e68751 against 95093e9 are in! @Garmelon

Medium changes (8✅)

• ✅ build/module/Mathlib.Analysis.InnerProductSpace.StarOrder//instructions: -3.2G (-9.2%)
• ✅ build/module/Mathlib.Geometry.Manifold.Algebra.LeftInvariantDerivation//instructions: -9.1G (-5.8%)
• ✅ build/module/Mathlib.RingTheory.Extension.Cotangent.Basic//instructions: -8.6G (-4.7%)
• ✅ build/module/Mathlib.RingTheory.Kaehler.Basic//instructions: -13.7G (-5.6%)
• ✅ build/module/Mathlib.RingTheory.Kaehler.JacobiZariski//instructions: -18.2G (-7.2%)
• ✅ build/module/Mathlib.RingTheory.Smooth.IntegralClosure//instructions: -8.6G (-5.1%)
• ✅ build/module/Mathlib.RingTheory.Smooth.Locus//instructions: -1.7G (-4.4%)
• ✅ build/module/Mathlib.RingTheory.Unramified.Finite//instructions: -2.7G (-4.3%)

Small changes (33✅, 2🟥)

Too many entries to display here. View the full report on radar instead.

[grunweg]

Can you add a similar comment about the instance priority? Otherwise, this looks great; thanks a lot!
maintainer delegate

[github-actions]

🚀 Pull request has been placed on the maintainer queue by grunweg.