Skip to content

feat(SimpleGraph): redefine cycleGraph independent of circulantGraph#35250

Open
vlad902 wants to merge 3 commits intoleanprover-community:masterfrom
vlad902:redef-cycle-graph
Open

feat(SimpleGraph): redefine cycleGraph independent of circulantGraph#35250
vlad902 wants to merge 3 commits intoleanprover-community:masterfrom
vlad902:redef-cycle-graph

Conversation

@vlad902
Copy link
Collaborator

@vlad902 vlad902 commented Feb 13, 2026

Right now the cycleGraph definition relies on circulantGraph which requires importing Group definitions from the algebra hierarchy. This causes large-imports for me in later PRs where I try to make more widespread use of cycleGraphs, so here I redefine it to be its own independent object, and leave moving it from Circulant.lean to another PR (this is parallel to #35084.)


Open in Gitpod

@vlad902 vlad902 changed the title feat(SimpleGraph): redefine cycleGraph independent of circulanGraph feat(SimpleGraph): redefine cycleGraph independent of circulantGraph Feb 13, 2026
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

PR summary 81b174f9de

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Feb 13, 2026
Right now the `cycleGraph` definition relies on `circulantGraph` which
requires importing Group definitions from the algebra hierarchy. This
causes large-imports for me in later PRs where I try to make more
widespread use of cycleGraphs, so here I redefine it to be its own
independent object, and leave splitting it from `circulantGraph` to
another PR (this is parallel to leanprover-community#35084.)
Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, I'm glad this is a simple change!

Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants