fix: add bibPrepass dependency to library_facet docs #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `library_facet docs` includes `references.bib` in its staticFiles array and attempts to compute its trace via `computeTrace`. However, this file is only created by the `bibPrepass` target, which runs before module documentation is generated. Without an explicit dependency on `bibPrepass`, Lake may attempt to compute the trace of `references.bib` before it exists, causing the build to fail with "no such file or directory" errors. This fix adds the missing `bibPrepass` dependency, matching the pattern already used in `module_facet docs` and `coreTarget`. Fixes leanprover-community/docgen-action#18 (the underlying cause)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "no such file or directory" error when building documentation with
lake build FooLib:docs.The
library_facet docsincludesreferences.bibin itsstaticFilesarray and attempts to compute its trace viacomputeTrace. However, this file is only created by thebibPrepasstarget.Without an explicit dependency on
bibPrepass, Lake may attempt to compute the trace ofreferences.bibbefore it exists, causing builds to fail with:This PR adds the missing
bibPrepassdependency tolibrary_facet docs, matching the pattern already used inmodule_facet docsandcoreTarget.🤖 Prepared with Claude Code