Skip to content

refactor: don't extend Applicative in Alternative #11925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JovanGerb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor: don't extend Applicative in Alternative #11925

JovanGerb wants to merge 4 commits into from

Conversation

@JovanGerb
Copy link
Contributor

@JovanGerb JovanGerb commented Jan 7, 2026

This PR changes Alternative to not extend Applicative. As a result, it is possible to have [Alternative m] and [Monad m] arguments without having multiple non-defEq Applicative m instances.

@JovanGerb JovanGerb requested review from kim-em and tydeu as code owners January 7, 2026 08:06
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 7, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 7, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11925
38e7320
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Jan 7, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 7, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11925
1db03e7
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jan 7, 2026
@leanprover-bot
Update lean-toolchain for testing leanprover/lean4#11925
6a9a8f7
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 7, 2026
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 7, 2026

Mathlib CI status (docs):

@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jan 7, 2026
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jan 7, 2026 •
edited
Loading

Reference manual CI status:

@JovanGerb
Copy link
Contributor Author

JovanGerb commented Jan 7, 2026

I didn't realize that ApplicativeFunctor already exists in Batteries. It's probably better to upstream that instead of doing this refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan builds-manual CI has verified that the Lean Language Reference builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JovanGerb @leanprover-community-bot @leanprover-bot