Skip to content

chore: extract shared match splitting impl from FunInd and mvcgen #11953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgraf812 merged 1 commit into from
Jan 9, 2026
Merged

chore: extract shared match splitting impl from FunInd and mvcgen #11953

sgraf812 merged 1 commit into from
Jan 9, 2026

Conversation

@sgraf812
Copy link
Contributor

@sgraf812 sgraf812 commented Jan 9, 2026

This was an indepedently viable refactoring proposed by Joachim. It fixes a bug in mvcgen exposed by the now reverted #11696.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 9, 2026
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 9, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 22bef1c45a50dc25fc88f0e8654467277ada3d27 --onto 0ad15fe98273448cff34de5b777550a82e09f5f9. You can force Mathlib CI using the force-mathlib-ci label. (2026-01-09 10:11:52)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jan 9, 2026

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 22bef1c45a50dc25fc88f0e8654467277ada3d27 --onto 0ad15fe98273448cff34de5b777550a82e09f5f9. You can force reference manual CI using the force-manual-ci label. (2026-01-09 10:11:54)

@sgraf812 sgraf812 marked this pull request as ready for review January 9, 2026 15:53
@sgraf812 sgraf812 requested a review from leodemoura as a code owner January 9, 2026 15:53
@sgraf812 sgraf812 enabled auto-merge January 9, 2026 15:53
@sgraf812 sgraf812 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into master with commit 15a719c Jan 9, 2026
18 checks passed
@sgraf812 sgraf812 deleted the sg/mvcgen-matcher-refactoring branch January 9, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sgraf812 @leanprover-community-bot @leanprover-bot