feat: introduce Headers data type for HTTP#12127
Open
algebraic-dev wants to merge 60 commits intosofia/async-http-datafrom
Open
feat: introduce Headers data type for HTTP#12127algebraic-dev wants to merge 60 commits intosofia/async-http-datafrom
Headers data type for HTTP#12127algebraic-dev wants to merge 60 commits intosofia/async-http-datafrom
Conversation
Headers data type.Headers data type
Headers data typeHeaders data type for HTTP
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This was referenced Jan 24, 2026
Rob23oba
suggested changes
Jan 25, 2026
Contributor
Rob23oba
left a comment
There was a problem hiding this comment.
I'm a bit confused by the isEmpty decidable instance but otherwise some small improvements and comments
Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
9b737c6 to
6e26b90
Compare
kim-em
reviewed
Jan 26, 2026
Rob23oba
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Headersdata type, that provides a good and convenient abstraction for parsing, querying, and encoding HTTP/1.1 headers.This contains the same code as #10478, divided into separate pieces to facilitate easier review.
The pieces of this feature are:
Headersdata type for HTTP #12127URIdata type for HTTP #12128Bodytype class and some Body types for HTTP #12144