-
Notifications
You must be signed in to change notification settings - Fork 745
feat: @[instance_reducible]
#12247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: @[instance_reducible]
#12247
+185
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 30, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 30, 2026
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
This panics all through Mathlib, here's an example: |
…er the fact, assume they already are
fc8f710 to
3d110dd
Compare
Member
Author
@kim-em It is the same panic that was affecting our stage2. It has been fixed. |
kim-em
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
changelog-language
Language features and metaprograms
mathlib4-nightly-available
A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new transparency setting
@[instance_reducible]. We used to check whether a declaration hadinstancereducibility by using theisInstancepredicate. However, this was not a robust solution because:We have scoped instances, and
isInstancereturnstrueonly if the scope is active.We have auxiliary declarations used to construct instances manually, such as:
isInstancealso returnsfalsefor this kind of declaration.In both cases, the declaration may be (or may have been) used to construct an instance, but
isInstancereturns
false. Thus, we claim it is a mistake to check the reducibility status usingisInstance.isInstanceindicates whether a declaration is available for the type class resolution mechanism,not its transparency status.
We are decoupling whether a declaration is available for type class resolution from its transparency status.
Remak: We need a update stage0 to complete this feature.