Conversation
Contributor
hargoniX
commented
Feb 27, 2026
hargoniX
commented
- step1
- step2
- feat: XID identifier support
Contributor
Author
|
!bench |
|
Benchmark results for 4fce392 against 9843794 are in! @hargoniX
No significant changes detected. |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Rob23oba
reviewed
Feb 27, 2026
|
|
||
| @[inline] def isIdRest (c : Char) : Bool := | ||
| c.isAlphanum || c = '_' || c = '\'' || c == '!' || c == '?' || isLetterLike c || isSubScriptAlnum c | ||
| c.isAlphanum || c = '_' || c = '\'' || c == '!' || c == '?' || c.isXID_Continue |
Contributor
There was a problem hiding this comment.
Don't forget subscript alnum!
Edit: or really numeric subscript since the others are already included
Edit 2: and it seems like we'll have to exclude the superscript alphabet (for e.g. ᵒᵈ). Not sure about lambda, pi and sigma since they might be good to have for Greek people using Lean
Rob23oba
reviewed
Feb 27, 2026
| | `($cmd₁ in%$tk $cmd₂) => | ||
| -- Limit ref variability for incrementality; see Note [Incremental Macros] | ||
| withRef tk `(section $cmd₁:command $endLocalScopeSyntax:command $cmd₂ end) | ||
| withRef tk `(section Aux $cmd₁:command $endLocalScopeSyntax:command $cmd₂ end Aux) |
Contributor
There was a problem hiding this comment.
Why do we need this? It seems like section doesn't like macro scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.