Update wording in DependentTypeTheory.lean#173
Open
ozgurakgun wants to merge 1 commit intoleanprover:masterfrom
Open
Update wording in DependentTypeTheory.lean#173ozgurakgun wants to merge 1 commit intoleanprover:masterfrom
ozgurakgun wants to merge 1 commit intoleanprover:masterfrom
Conversation
I am being pedantic here but the following sentence is technically incorrect as it is written: "Like sections, nested namespaces have to be closed in the order they are opened" The intended meaning is that they should be closed in the reverse order. I suggest an alternative wording here, but perhaps another alternative could be saying "last-in, first-out" more directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am being pedantic here but the following sentence is technically incorrect as it is written:
"Like sections, nested namespaces have to be closed in the order they are opened"
The intended meaning is that they should be closed in the reverse order. I suggest an alternative wording here, but perhaps another alternative could be saying "last-in, first-out" more directly.