fix: Don't include syntax information in elaboration of math elements #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add LSP tests for Verso documents; we reuse the core LSP testing infrastructure from lean4 upstream. See `doc/dev/testing.md` there for more details. Co-authored-by: David Thrane Christiansen <[email protected]>
We did push `genre` and `title` to the last block syntax, but this broke the infotree span invariant, causing problems when retrieving the goals. Co-authored-by: David Thrane Christiansen <[email protected]>
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <[email protected]>
ejgallego
force-pushed
the
remove_info_verso_math
branch
from
3e95b30 to
22a43cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids spurious infoview display of the internal elaborated
constant type.
This bug is only observable after applying the fix in #700 ; will wait
for #700 and #699 to merge this so we can properly provide a test.
Co-authored-by: David Thrane Christiansen [email protected]