Conversation
| } | ||
|
|
||
| c := executor.New("remote-target-check-group", actorInput) | ||
| c := executor.New("remote-target-check-group-v2", actorInput) |
There was a problem hiding this comment.
Why do you want to add -v2? Can't you change actual actor? Is it because something different is using remote-target-check-group "v1"?
| } | ||
|
|
||
| c := executor.New("port-mapping", string(actorInput)) | ||
| c := executor.New("port-mapping-v2", string(actorInput)) |
There was a problem hiding this comment.
the same question as above
|
Ah I'm reading the description from JIRA.. so right now ignore my comments. I have to understand what you wrote there and then I will remove my questions or I will continue asking :) |
|
Guys, we should really talk about practices of PR. It's nice to mention, that there is some Jira for internals, but the PR should carry complete info about its purpose so it will be available for everyone in future, who look at here. |
|
@pirat89 Yeah actually I said so - just we did not write it here - Basically the JIRA tickets shoudn't actually be referenced here at all due to the fact that they aren't openly accessible |
4 participants
leapp-to/snactor#55 should be merged before this one.