Skip to content

Add env-based time limits #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aobolensk merged 8 commits into from
Jul 6, 2025
Merged

Add env-based time limits #525

aobolensk merged 8 commits into from
Jul 6, 2025

Conversation

@aobolensk
Copy link
Member

@aobolensk aobolensk commented Jul 5, 2025 •
edited
Loading

  • read optional env vars PPC_TASK_MAX_TIME and PPC_PERF_MAX_TIME
  • use those env vars when checking execution time
  • document new environment variables
  • add regression tests for the env vars

@aobolensk aobolensk requested a review from allnes as a code owner July 5, 2025 17:08
allnes
allnes requested changes Jul 5, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (8b3e8fb) to head (e4fde35).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   94.57%   94.72%   +0.15%     
==========================================
  Files          11       11              
  Lines         350      360      +10     
  Branches      117      122       +5     
==========================================
+ Hits          331      341      +10     
  Misses          5        5              
  Partials       14       14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Coverage report is available for download
here

@aobolensk aobolensk mentioned this pull request Jul 6, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

Coverage report is available for download
here

@aobolensk aobolensk added this pull request to the merge queue Jul 6, 2025
Merged via the queue into master with commit 8ee6414 Jul 6, 2025
81 checks passed
@aobolensk aobolensk deleted the erh8hi-codex/add-optional-environment-variables branch July 7, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allnes allnes allnes approved these changes

Assignees

No one assigned

Labels

codex docs modules:performance modules:task modules:util

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aobolensk @allnes