-
Notifications
You must be signed in to change notification settings - Fork 19
Литвяков Даниил. Технология SEQ-MPI. Нахождение минимальных значений по столбцам матрицы. Вариант 18 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Литвяков Даниил. Технология SEQ-MPI. Нахождение минимальных значений по столбцам матрицы. Вариант 18 #63
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 27.27% 30.52% +3.25%
==========================================
Files 45 47 +2
Lines 1738 1831 +93
Branches 676 718 +42
==========================================
+ Hits 474 559 +85
Misses 1232 1232
- Partials 32 40 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ## 6. Характеристики локальной машины | ||
| - Аппаратное обеспечение/Операционная система: AMD Ryzen 5 5600, 32 GB DDR4-3200, Windows 10. | ||
| - Компилятор: MSVC, Тип сборки: Release. | ||
| - Данные: сгенерированная матрица матрица размерами 4000 на 4000 с элементами от -1e-6 до 1e-6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your elements are not like that in the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправлено
| return std::cmp_equal(res.size(), m); | ||
| } | ||
|
|
||
| bool LitvyakovDMinValByColMPI::RunImpl() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see data scatter from rank 0 to other ranks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправлено
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This pull request is stale for 2 weeks and is going to be closed in a week |
В параллельной версии каждому процессу столбцы делятся почти поровну между процессами(за исключением остатка). После вычисления локальных минимумов промежуточные результаты объединяются в финальный с помощью MPI_Gatherv.
Чек-лист
litvyakov_d_min_val_by_colclang-formatлокально в моем форке (нет ошибок форматирования)clang-tidyлокально в моем форке (нет предупреждений/ошибок)nesterov_a_vector_sum), а не вmaster