Remove node-sass in favour of sass (Dart sass)#1065
Open
rtibbles wants to merge 6 commits intolearningequality:developfrom
Open
Remove node-sass in favour of sass (Dart sass)#1065rtibbles wants to merge 6 commits intolearningequality:developfrom
rtibbles wants to merge 6 commits intolearningequality:developfrom
Conversation
…-loader until we use Vue 3 (and so can use a newer version of Nuxt + Webpack).
…licit previously.
Contributor
Percy Visual Test ResultsPercy Dashboard: View Detailed Report Environment:
Instructions for Reviewers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Needed for learningequality/kolibri-ecosystem#47
Before/after screenshots
Possibly impacting every part of KDS, so will need cross checking.
Changelog
Steps to test
This will require fairly in depth QA, but should be sufficient within documentation for now.
(optional) Implementation notes
At a high level, how did you implement this?
Upgraded. Fixed all deprecation warnings while ensuring the build didn't break. Noting that this was mostly implemented autonomously by Claude-Code while I monitored and verified the results.