Fix/channel details in channel #5540
Open
+1,294
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtushar06
force-pushed
the
fix/channel-details-in-channel
branch
from
61e0727 to
5c41386
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated ChannelDetailsModal from Vuetify to Kolibri Design System (KDS) by creating three new reusable components:
New Components:
StudioChip: Replaces VChip for displaying tags and metadata with consistent rounded styling
StudioDetailsRow: Replaces VLayout/VFlex with CSS Grid for semantic detail rows with label/value pairs
StudioDetailsPanel: Complete KDS rewrite of DetailsPanel using KImg, KTooltip,semantic
lists- Replaced Vuetify components (VCard, VLayout, VFlex, VChip, VTooltip, VDataTable) with KDS equivalents
- Used CSS Grid and Flexbox for all layouts
- Implemented KImg with 16:9 aspect ratio for channel thumbnails
- Added comprehensive unit tests (19 tests passing) using @testing-library/vue
- Check RTL language support
- Run unit tests: npm test StudioChip StudioDetailsRow StudioDetailsPanel
Key Changes:
Screen-Recording:
Channel.details.modal.mp4
…
References
fixes : #5530
…
Reviewer guidance
…