Skip to content

[Remove Vuetify from Studio] Content Library catalog page (#5526) #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vtushar06 wants to merge 10 commits into
base: channel-cards
Choose a base branch
from
+264 −200
Open

[Remove Vuetify from Studio] Content Library catalog page (#5526) #5616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
789809d
added StudioCatalogList.vue following past PRs
vtushar06 Dec 19, 2025
40e62b0
fixed UI for select button
vtushar06 Dec 19, 2025
a4d96a3
fixed import in router for StudioCatalogList
vtushar06 Dec 19, 2025
1823d79
Added Checkbox in StudioChannalCaard with select slot
vtushar06 Dec 19, 2025
b27335e
changes unit tests frron test-utils to vue testing library
vtushar06 Dec 19, 2025
41585fc
update import for CatalogList component in router
vtushar06 Dec 19, 2025
850c003
replace Checkbox with KCheckbox and update selection logic in Catalog…
vtushar06 Dec 19, 2025
fe88025
remove StudioCatalogList component and its associated styles
vtushar06 Dec 19, 2025
0635b3e
rename StudioCatalogList to CatalogList in tests
vtushar06 Dec 19, 2025
c5ceb61
remove unused detailsRouteName
vtushar06 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 41 additions & 27 deletions contentcuration/contentcuration/frontend/channelList/views/Channel/CatalogList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,34 +39,36 @@
appearance="basic-link"
@click="setSelection(true)"
/>
<Checkbox
<KCheckbox
v-else-if="selecting"
v-model="selectAll"
Copy link
Member

@MisRob MisRob Jan 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this place, we can keep v-model - it will be simpler to maintain.

I think that when you implemented this PR, KCheckbox didn't yet support v-model, but we recently implemented it - you can see the latest documentation. You will need to merge latest unstable to this branch and run pnpm install so that you have access to the latest KDS version.

Copy link
Member

@MisRob MisRob Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, when I was writing this I forgot for a moment that we're targeting channel-cards. So actually let's wait a bit for this update until I do this and then you can resolve it together with test conflicts.

class="mb-4 mx-2"
:checked="selectAll"
:indeterminate="isIndeterminate"
:label="$tr('selectAll')"
data-test="select-all"
:indeterminate="selected.length > 0 && selected.length < channels.length"
class="mb-4 mx-2"
@change="toggleSelectAll"
/>
</VFlex>
<VFlex xs12>
<VLayout
v-for="item in channels"
:key="item.id"
align-center
<KCardGrid
layout="1-1-1"
:skeletonsConfig="[
{
breakpoints: [0, 1, 2, 3, 4, 5, 6, 7],
orientation: 'vertical',
count: 3,
},
]"
>
<Checkbox
v-show="selecting"
v-model="selected"
class="mx-2"
:value="item.id"
data-test="checkbox"
<StudioChannelCard
v-for="channel in channels"
:key="channel.id"
:channel="channel"
:selectable="selecting"
:selected="isChannelSelected(channel.id)"
@toggle-selection="handleSelectionToggle"
/>
<ChannelItem
:channelId="item.id"
:detailsRouteName="detailsRouteName"
style="flex-grow: 1; width: 100%"
/>
</VLayout>
</KCardGrid>
</VFlex>
<VFlex
xs12
Expand Down Expand Up @@ -130,11 +132,10 @@
import union from 'lodash/union';
import { RouteNames } from '../../constants';
import CatalogFilters from './CatalogFilters';
import ChannelItem from './ChannelItem';
import StudioChannelCard from './components/StudioChannelCard';
import LoadingText from 'shared/views/LoadingText';
import Pagination from 'shared/views/Pagination';
import BottomBar from 'shared/views/BottomBar';
import Checkbox from 'shared/views/form/Checkbox';
import ToolBar from 'shared/views/ToolBar';
import OfflineText from 'shared/views/OfflineText';
import { constantsTranslationMixin } from 'shared/mixins';
Expand All @@ -143,12 +144,11 @@
export default {
name: 'CatalogList',
components: {
ChannelItem,
StudioChannelCard,
LoadingText,
CatalogFilters,
Pagination,
BottomBar,
Checkbox,
ToolBar,
OfflineText,
},
Expand Down Expand Up @@ -202,9 +202,6 @@
debouncedSearch() {
return debounce(this.loadCatalog, 1000);
},
detailsRouteName() {
return RouteNames.CATALOG_DETAILS;
Copy link
Member

@MisRob MisRob Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for removing this part?

},
channels() {
// Sort again by the same ordering used on the backend - name.
// Have to do this because of how we are getting the object data via getChannels.
Expand All @@ -213,6 +210,9 @@
selectedCount() {
return this.page.count - this.excluded.length;
},
isIndeterminate() {
return this.selected.length > 0 && this.selected.length < this.channels.length;
},
},
watch: {
$route(to) {
Expand All @@ -236,6 +236,20 @@
},
methods: {
...mapActions('channelList', ['searchCatalog']),
isChannelSelected(channelId) {
return this.selected.includes(channelId);
},
handleSelectionToggle(channelId) {
const currentlySelected = this.selected;
if (currentlySelected.includes(channelId)) {
this.selected = currentlySelected.filter(id => id !== channelId);
} else {
this.selected = [...currentlySelected, channelId];
}
},
toggleSelectAll() {
this.selectAll = !this.selectAll;
},
loadCatalog() {
this.loading = true;
const params = {
Expand Down
Loading