Skip to content

Conversation

@TamaroWalter
Copy link
Member

This PR adapts the repo to the new changes of Moodle 5.0.

Changes made:

  • update moodle ci to moodle 5.0

Todo's:

@TamaroWalter TamaroWalter added the WIP work in progress - not ready to merge label Jul 1, 2025
@TamaroWalter TamaroWalter requested review from bluetom and dlmsr July 23, 2025 20:30
@TamaroWalter TamaroWalter removed the WIP work in progress - not ready to merge label Jul 23, 2025
@dlmsr
Copy link
Member

dlmsr commented Sep 17, 2025

I have rebased the changes onto main and re-arranged some commits. I
have also removed the allow-mustache-lint-error part which was
questioned by @bluetom. Then, I updated the thirdparty library
endroid/qr-code to the latest release 6.0.0. Let’s see what CI has to
say.

@dlmsr
Copy link
Member

dlmsr commented Oct 1, 2025

As discussed with @bluetom and @TamaroWalter I have removed two commits and pushed a v3 of this branch. We agreed on making the code checker ignore the thirdparty/ code since it violates Moodle coding standards anyway so there is no point in checking for it. @TamaroWalter will adapt the central Learnweb workflow files to make this work. Since we want to support 4.1 for a couple of weeks, we cannot upgrade the endroid/qr-code library to a newer version because the required PHP versions would be incompatible. We stick with the current 4.x version for now.

@dlmsr
Copy link
Member

dlmsr commented Oct 1, 2025

I have just noticed that the problems do not arise with the code checker. The vendor directories are excluded in MoodleHQ's PHPCodeSniffer standard anyways. The problems arise in the Behat and PHPUnit tests directly.

@dlmsr
Copy link
Member

dlmsr commented Oct 28, 2025

I have found a way to make PHPUnit ignore deprecations in third-party code in the docs. I tested this locally and had to adapt Moodle's phpunit.xml.dist file to achieve it. To test this locally, I built a container based on moodlehq/moodle-php-apache:8.4 and run the following sed command to adapt phpunit.dist.xml:

sed -i 's/<source>/<source ignoreIndirectDeprecations="true">/' /var/www/html/phpunit.xml.dist

Then running php admin/tool/phpunit/cli/init.php uses this template and builds a phpunit.xml containing everything.

However, scanning through the moodle-plugin-ci source, it might be possible to simply place a phpunit.xml into our plugin source tree and it should be The Right Thing™.

@dlmsr dlmsr self-assigned this Oct 28, 2025
@TamaroWalter
Copy link
Member Author

Okay, I'll try it

@dlmsr
Copy link
Member

dlmsr commented Oct 28, 2025

@TamaroWalter, could you please move add new admin setting for custom host name (bb9b361) into a new PR for issue #55?

I am tackling #52.

@dlmsr dlmsr added this to the Release 5.0.0 milestone Nov 3, 2025
@dlmsr dlmsr force-pushed the update/500 branch 3 times, most recently from 13e9246 to 0683bb2 Compare November 4, 2025 12:30
@dlmsr dlmsr marked this pull request as draft November 4, 2025 12:31
@dlmsr dlmsr marked this pull request as ready for review November 6, 2025 09:11
@dlmsr dlmsr merged commit 597c299 into main Nov 6, 2025
12 checks passed
@TamaroWalter TamaroWalter deleted the update/500 branch November 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants