codechecker issues

Author: bluetom

classes/local/manager/delayed_courses_manager.php

@@ -101,7 +101,7 @@ public static function get_delayed_courses_for_workflow($workflowid) {
      * Creates an instance of a delayed course.
      * @param int $courseid id of the course
      * @param int $duration number of seconds
-     * @param int $type 1 for rollback, 2 for finish
+     * @param int $delaytype 1 for rollback, 2 for finish
      * @throws \dml_exception
      */
     public static function set_course_delayed($courseid, $duration, $delaytype = 0) {

db/upgrade.php

@@ -45,7 +45,7 @@ function tool_lifecycle_fix_workflow_sortindex() {
  * @param string $dir
  * @return void
  */
-function tool_lifecycle_upgrade_removeDir(string $dir): void {
+function tool_lifecycle_upgrade_removedir(string $dir): void {
     $it = new RecursiveDirectoryIterator($dir, RecursiveDirectoryIterator::SKIP_DOTS);
     $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
     foreach($files as $file) {
@@ -594,11 +594,11 @@ function xmldb_tool_lifecycle_upgrade($oldversion) {
         }
 
         if ($dir = core_component::get_plugin_directory('lifecycletrigger', 'sitecourse')) {
-            tool_lifecycle_upgrade_removeDir($dir);
+            tool_lifecycle_upgrade_removedir($dir);
         }
 
         if ($dir = core_component::get_plugin_directory('lifecycletrigger', 'delayedcourses')) {
-            tool_lifecycle_upgrade_removeDir($dir);
+            tool_lifecycle_upgrade_removedir($dir);
         }
 
         upgrade_plugin_savepoint(true, 2025041600, 'tool', 'lifecycle');

workflowoverview.php

@@ -52,7 +52,7 @@
 $delayed = optional_param('delayed', null, PARAM_INT);
 $used = optional_param('used', null, PARAM_INT);
 $search = optional_param('search', null, PARAM_RAW);
-$showdetails = optional_param('showdetails', 0,PARAM_INT);
+$showdetails = optional_param('showdetails', 0, PARAM_INT);
 
 $workflow = workflow_manager::get_workflow($workflowid);
 $iseditable = workflow_manager::is_editable($workflow->id);