line break in course list of plain text email, nicer course list popup in wf overview

bluetom · bluetom · commit a081c8a66747 · 2025-03-17T19:47:00.000+01:00
diff --git a/step/email/lib.php b/step/email/lib.php
@@ -178,7 +178,7 @@ private function replace_placeholders($strings, $user, $stepid, $mailentries) {
         $coursesstring = '';
         $coursesstring .= $this->parse_course(array_pop($courses)->courseid);
         foreach ($courses as $entry) {
-            $coursesstring .= "\n" . $this->parse_course($entry->courseid);
+            $coursesstring .= "\r\n" . $this->parse_course($entry->courseid);
         }
         $replacements[] = $coursesstring;
 
diff --git a/styles.css b/styles.css
@@ -98,7 +98,7 @@ span.tool_lifecycle-hint {
 }
 
 #lifecycle-workflow-details .courses-table {
-    flex: 40% 1 1;
+    flex: 45% 1 1;
     border: 1px solid #bbb;
     margin-right: 2em;
 }

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ private function replace_placeholders($strings, $user, $stepid, $mailentries) {`
`178`	`178`	`$coursesstring = '';`
`179`	`179`	`$coursesstring .= $this->parse_course(array_pop($courses)->courseid);`
`180`	`180`	`foreach ($courses as $entry) {`
`181`		`- $coursesstring .= "\n" . $this->parse_course($entry->courseid);`
	`181`	`+ $coursesstring .= "\r\n" . $this->parse_course($entry->courseid);`
`182`	`182`	`}`
`183`	`183`	`$replacements[] = $coursesstring;`
`184`	`184`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ span.tool_lifecycle-hint {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`#lifecycle-workflow-details .courses-table {`
`101`		`- flex: 40% 1 1;`
	`101`	`+ flex: 45% 1 1;`
`102`	`102`	`border: 1px solid #bbb;`
`103`	`103`	`margin-right: 2em;`
`104`	`104`	`}`