Skip to content

Conversation

@chrisdenman
Copy link
Contributor

@chrisdenman chrisdenman commented Sep 27, 2024

Hi,

This PR contains:

  • Quite a few HTML fixes to make the files more standards compliant
  • Setting the height of an image to reflect the actual size (this will help with faster page layouts (no flashes)) + another for an image width declaration that was off by 1.
  • Making links https instead of https
  • Adding a .gitignore file
  • A few JavaScript fixes to use e.g. const/let instead of var and, using === instead of == where appicable
  • A couple of spelling issues

As part of this work and, to ensure that I've not regressed anything, I created a new project (test.learnyouahaskell.github.io) which is dedicated to functionally testing your site. This projects contains some standard stuff (checking links work, checking link text, ... ). Also, it goes through the site taking screenshots using both firefox and chrom (on Linux) at two different browser widths (860 & 1024 currently). Then, I use ImageMagick to compare the screenshots from the PR branch with that from the live site.

I ensure that the screenshot directories contain identicall named files. After that, if the ImageMagick image signature for a screenshots indicates that there is a difference, I create a flicker image (animated gif) to easily check the visual differences.

Please find these flicker diagrams attached. There's nothing major. They show the two spelling instances, the image height correction and a similar image width correction.

I have not checked in the functional testing project yet... I want to tidy it up a bit more before I do, it's a little invovled and has no documentation presently. I hope to complete that this weekend. As part of getting the project onto GH I shall ensure that we have a complete set of screenshots of the current production site that we can use as a base going forwards.

I hope you find this useful. I think it will be useful going forwards for generating the site from markdown should that be an aim people find useful.

Thanks! Any comments/suggestions will be gladly received.

flickers_chrome_860_chapter-a-fistful-of-monads_0
flickers_chrome_860_chapter-functionally-solving-problems_6
flickers_chrome_860_chapters_4
flickers_chrome_860_faq
flickers_chrome_1024_chapter-a-fistful-of-monads_0
flickers_chrome_1024_chapter-functionally-solving-problems_6
flickers_chrome_1024_chapters_4
flickers_chrome_1024_faq
flickers_firefox_860_chapter-a-fistful-of-monads_0
flickers_firefox_860_chapter-functionally-solving-problems_6
flickers_firefox_860_chapters_4
flickers_firefox_860_faq
flickers_firefox_1024_chapter-a-fistful-of-monads_0
flickers_firefox_1024_chapter-functionally-solving-problems_6
flickers_firefox_1024_chapters_4
flickers_firefox_1024_faq

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdenman great work! We don't store HTML anymore (we generate it from Markdown on the fly). an you verify that this PR doesn't bring anything valuable anymore? If not, please, rebase/update.

@ulysses4ever ulysses4ever added enhancement New content or edit request blocked labels Dec 17, 2025
@chrisdenman
Copy link
Contributor Author

It's been a while, I'll send and update soon...

@chrisdenman
Copy link
Contributor Author

Some of these still apply, some have been fixed.

I'm happy to re-work them, and submit them against the markdown source files.

How do you want them managed, one big PR or individual ones?

@ulysses4ever
Copy link
Collaborator

Probably, separate PRs would be best, if it's not too much trouble. If it is, exercise your judgment for how many pieces you have energy to split it into. Separate commits in one PR may be a middle ground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked enhancement New content or edit request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants