This repository was archived by the owner on Oct 28, 2020. It is now read-only.
Allow version to be passed as parameter to DSN#11
Open
fabiang wants to merge 1 commit intoleaseweb:masterfrom
fabiang:version-param
Open
Allow version to be passed as parameter to DSN#11fabiang wants to merge 1 commit intoleaseweb:masterfrom fabiang:version-param
fabiang wants to merge 1 commit intoleaseweb:masterfrom
fabiang:version-param
Conversation
raztud
approved these changes
Mar 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allow the version to be passed as parameter to the DSN string via config as suggested here: http://php.net/manual/de/ref.pdo-dblib.connection.php#118644
When I set version=8.0 this fixes some Unicode errors and should be very useful for users of this library.