develop -> main fix: Reconcile host membership in EnsureLoadBalancer for existing rules + golangci-lint update#111
Merged
Conversation
During node rollouts, hosts can become un-associated from LB rules because EnsureLoadBalancer only assigned hosts when creating new rules. Since Kubernetes does not guarantee UpdateLoadBalancer is called reliably during rapid rollouts, existing rules could end up with stale membership. Extract a shared reconcileHostsForRule helper that lists current members, computes the symmetric difference, and assigns new hosts before removing old ones. Both EnsureLoadBalancer and UpdateLoadBalancer now use this helper, eliminating duplication and ensuring host membership is always reconciled regardless of which code path runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix/Ensure host assocation with LB rules in EnsureLoadBalancer
hrak
requested review from
CientistaDaWeb,
FarnazBGH,
jpsfalcao,
kasperhendriks,
lanord and
suhasagasthya
FarnazBGH
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
During node rollouts, hosts can become un-associated from LB rules
because EnsureLoadBalancer only assigned hosts when creating new rules.
Since Kubernetes does not guarantee UpdateLoadBalancer is called reliably
during rapid rollouts, existing rules could end up with stale membership.
Extract a shared reconcileHostsForRule helper that lists current members,
computes the symmetric difference, and assigns new hosts before removing
old ones. Both EnsureLoadBalancer and UpdateLoadBalancer now use this
helper, eliminating duplication and ensuring host membership is always
reconciled regardless of which code path runs.
Update golangci-lint to v1.64.8 + fix existing lint issues.
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.