Conversation
hrak
requested review from
FarnazBGH,
jpsfalcao,
kasperhendriks,
lanord and
suhasagasthya
When createLoadBalancerRule is called with an empty protocol, the API will return the loadbalancerrule without a protocol field defined when calling listLoadBalancerRules. CloudStack appears to default to TCP in this case, but this is not reflected in listLoadBalancerRulesResponse
getLoadBalancerByID queries by publicipid+networkid, which returns all LB rules on that IP — including rules belonging to other services. The cleanup loop in EnsureLoadBalancer then deletes these foreign rules. Apply filterRulesByPrefix (already used in getLoadBalancerByName) to keep only rules matching the current service's name prefix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpsfalcao
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR fixes two bugs:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.