feat(web): add scroll progress bar to support guide pages#2206
Open
feat(web): add scroll progress bar to support guide pages#2206
Conversation
Contributor
|
Leather Web build 57c946d — Web preview, Web test report |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2206 +/- ##
==========================================
- Coverage 12.45% 12.45% -0.01%
==========================================
Files 2420 2421 +1
Lines 100139 100164 +25
Branches 4173 4174 +1
==========================================
Hits 12477 12477
- Misses 86634 86659 +25
Partials 1028 1028
🚀 New features to boost your workflow:
|
kyranjamie
reviewed
Mar 12, 2026
Comment on lines
+26
to
+41
| function useScrollProgress() { | ||
| const [progress, setProgress] = useState(0); | ||
|
|
||
| useEffect(() => { | ||
| function handleScroll() { | ||
| const scrollTop = window.scrollY; | ||
| const docHeight = document.documentElement.scrollHeight - window.innerHeight; | ||
| setProgress(docHeight > 0 ? Math.min(scrollTop / docHeight, 1) : 0); | ||
| } | ||
|
|
||
| window.addEventListener('scroll', handleScroll, { passive: true }); | ||
| return () => window.removeEventListener('scroll', handleScroll); | ||
| }, []); | ||
|
|
||
| return progress; | ||
| } |
Contributor
There was a problem hiding this comment.
This could better live in a separate directory that it can be reused
Made-with: Cursor
mica000
force-pushed
the
feat/support-scroll-progress-bar
branch
from
d7ba444 to
ae36a7c
Compare
Made-with: Cursor
Contributor
Author
|
Addressed your feedback! Moved the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
/support/install-leather)Made with Cursor