Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion simple_parsing/wrappers/field_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ def get_arg_options(self) -> dict[str, Any]:
_arg_options.pop("metavar", None)

elif utils.is_optional(self.type) or self.field.default is None:
_arg_options["required"] = False
if not self.field.metadata.get("positional"):
_arg_options["required"] = False

if utils.is_optional(self.type):
type_arguments = utils.get_args(self.type)
Expand Down
12 changes: 12 additions & 0 deletions test/test_optional.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import pytest

import simple_parsing
from simple_parsing import ArgumentParser

from .testutils import TestSetup
Expand Down Expand Up @@ -142,3 +143,14 @@ class Bob(TestSetup):
# actual = SomeDataclass.setup(f"--some_attribute {passed_value}")
# assert actual.some_attribute == expected_value
# assert isinstance(actual.some_attribute, some_type)


def test_optional_positional():
"""Test a optional positional argument."""

@dataclass
class Foo(TestSetup):
a: Optional[int] = simple_parsing.field(positional=True, default=None)

assert Foo.setup("") == Foo(a=None)
assert Foo.setup("1") == Foo(a=1)