Sync Custom Start Degree with Numbering Position#24
Open
seanalexander wants to merge 3 commits intoleechwort:masterfrom
Open
Sync Custom Start Degree with Numbering Position#24seanalexander wants to merge 3 commits intoleechwort:masterfrom
seanalexander wants to merge 3 commits intoleechwort:masterfrom
Conversation
feat: Sync Custom Start Degree with Numbering Position - Added logic to automatically update the Custom Start Degree when the Numbering Position is selected, ensuring synchronization between the two options. - Custom Start Degree now reflects the corresponding angle (0, 90, 180, or 270 degrees) based on the chosen Numbering Position (Top, Left, Right, Bottom). - Preserved flexibility: Custom Start Degree can still be manually overridden by the user.
Owner
|
Hi! Thank you for your contribution, I will check your PR asap! |
Owner
|
Hi @seanalexander! I'm testing your PR on my side, here is what I've got.
Setting "Right" looks weird:
My inkscape version: Inkscape 1.3.2 (1:1.3.2+202404261509+091e20ef0f) on linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Summary:
This PR introduces a feature that automatically synchronizes the Custom Start Degree field with the Numbering Position. When a user selects a numbering position (Top, Left, Right, Bottom), the corresponding angle (0, 90, 180, 270 degrees) is automatically set in the Custom Start Degree input, ensuring consistent behavior between the two options.
Changes:
Impact:
Testing: