-
Notifications
You must be signed in to change notification settings - Fork 431
Break pseudo token #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Break pseudo token #422
Conversation
a966b4a
to
3124fa0
Compare
So THAT'S how you deal with color bleed! Good to know, and do want! |
That 'B' stuff on the regex took me a bit too long to understand, so a comment would've been appreciated 🙂 Apart from that, the code looks good to me, and worked as expected on a few tests. |
Actually I should refactor this code to properly adapt it to the master branch. Right now it's a bit messy. I'll still add the original author as coauthor. |
Co-authored-by: Urs Ganse <[email protected]>
3124fa0
to
c35baca
Compare
I've finally remembered that I had this PR pending. I've just upstreamed it and it seems to work nicely. |
// (abc:3.12) - increases attention to abc by a multiplier of 3.12 | ||
// [abc] - decreases attention to abc by a multiplier of 1.1 | ||
// BREAK - separates the prompt into conceptually distinct parts for sequential processing | ||
// B - internal helper pattern; prevents 'B' in 'BREAK' from being consumed as normal text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is enough to make the regex a little less magical. Thanks!
I've noticed that #285 hasn't been updated for a while so I've upstreamed the PR and fixed the regex to correctly identify the BREAK token without deleting the white spaces.
@ursg I've still marked you as the author as most of the work was yours, if you still want to update your PR instead I'll close this.