Skip to content

Conversation

leejet
Copy link
Owner

@leejet leejet commented Oct 19, 2025

.\bin\Release\sd.exe --diffusion-model  ..\models\flux1-dev-q8_0.gguf --vae ..\..\ComfyUI\models\vae\ae.sft --clip_l ..\..\ComfyUI\models\clip\clip_l.safetensors --t5xxl ..\..\ComfyUI\models\clip\t5-v1_1-xxl-encoder-Q8_0.gguf  -p "a lovely cat holding a sign says 'flux.cpp'" --cfg-scale 1.0 --sampling-method euler -v

Without shift factor
without_shift_factor

With shift factor
with_shift_factor

@Green-Sky
Copy link
Contributor

Seems to slightly reduce the vertical lines, but hard to tell.
Maybe test with less steps or lower quant?

@stduhpf
Copy link
Contributor

stduhpf commented Oct 19, 2025

theyre-the-same-picture-3

@Green-Sky
Copy link
Contributor

Green-Sky commented Oct 19, 2025

image

diff boosted

animated:
shift_anim1
shift_anim1_labels_2x
(a -> after, b -> before)

@stduhpf
Copy link
Contributor

stduhpf commented Oct 19, 2025

Looks to have about the same diff as VAE tiling on vs off, maybe even less

@leejet
Copy link
Owner Author

leejet commented Oct 19, 2025

I didn’t really pay attention to the differences in the vertical lines — the purpose of this PR is simply to follow the official pipeline and include the handling of the shift factor.

@Green-Sky
Copy link
Contributor

I didn’t really pay attention to the differences in the vertical lines — the purpose of this PR is simply to follow the official pipeline and include the handling of the shift factor.

I figured as much, bit it still lowers the vertical line artifacts a bit. At least with that limited testing. I'm currently looking into chroma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants