Skip to content

Add Zstd support#56

Merged
oschulz merged 2 commits intomainfrom
zstd-support
Jul 22, 2025
Merged

Add Zstd support#56
oschulz merged 2 commits intomainfrom
zstd-support

Conversation

@oschulz
Copy link
Copy Markdown
Contributor

@oschulz oschulz commented Jul 22, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (8d7d5e3) to head (90df822).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   56.56%   56.56%           
=======================================
  Files           7        7           
  Lines         769      769           
=======================================
  Hits          435      435           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz oschulz merged commit 90df822 into main Jul 22, 2025
10 of 11 checks passed
@oschulz oschulz deleted the zstd-support branch July 22, 2025 13:43
@theHenks
Copy link
Copy Markdown

It seems like the downgrade tests on 1.10 failed due to compatibility issues. Did you have a look into that?

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Jul 22, 2025

This downgrade stuff is getting annoying. :-)

@fhagemann
Copy link
Copy Markdown
Contributor

@oschulz is there any reason to restrict this to 0.1.2 specifially (what about 0.1.1, 0.2)?
if yes, you can always exclude packages from Downgrade, in the skip section.

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Jul 22, 2025

is there any reason to restrict this to 0.1.2 specifially (what about 0.1.1, 0.2)?

I don't think there is a version 0.2 (yet): https://github.com/JuliaRegistries/General/blob/master/H/H5Zzstd/Versions.toml

v0.1.2 came out a while ago, I thought it safest not to allow older (possibly buggy) versions.

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Jul 22, 2025

Downgrade testing may be useful to check if currently allowed versions don't work, but it can hardly ensure older versions do work - even with 100% test coverage that wouldn't be guaranteed without special regression tests for known bugs in dependencies. I don't know if there are any problems with older versions of H5Zzstd, but why invite trouble. Requiring v0.1.2 won't hold any other dependencies back, as H5Zzstd is pretty orthogonal.

@fhagemann
Copy link
Copy Markdown
Contributor

I see, I just looked at the source code, but this is already planning for HDF5@0.18

https://github.com/JuliaIO/HDF5.jl/blob/master/filters/H5Zzstd/Project.toml

@fhagemann
Copy link
Copy Markdown
Contributor

Then feel free to exclude H5Zzstd from the Downgrade tests.

@fhagemann
Copy link
Copy Markdown
Contributor

Only thing is that HDZzstd@0.1.2 requires HDF5@0.17 minimum.
https://github.com/JuliaIO/HDF5.jl/blob/H5Zzstd-v0.1.2/filters/H5Zzstd/Project.toml

That’s why downgrade fails right now.
No way HDF5@0.16 can support HDZzstd@0.1.2

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Jul 23, 2025

Fine, then let's lower the version bound for H5Zzstd.

@theHenks theHenks linked an issue Jul 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for HDF5 ZFS filter (ID 32000)

3 participants