Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 56.56% 56.56%
=======================================
Files 7 7
Lines 769 769
=======================================
Hits 435 435
Misses 334 334 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems like the downgrade tests on 1.10 failed due to compatibility issues. Did you have a look into that? |
|
This downgrade stuff is getting annoying. :-) |
|
@oschulz is there any reason to restrict this to 0.1.2 specifially (what about 0.1.1, 0.2)? |
I don't think there is a version 0.2 (yet): https://github.com/JuliaRegistries/General/blob/master/H/H5Zzstd/Versions.toml v0.1.2 came out a while ago, I thought it safest not to allow older (possibly buggy) versions. |
|
Downgrade testing may be useful to check if currently allowed versions don't work, but it can hardly ensure older versions do work - even with 100% test coverage that wouldn't be guaranteed without special regression tests for known bugs in dependencies. I don't know if there are any problems with older versions of H5Zzstd, but why invite trouble. Requiring v0.1.2 won't hold any other dependencies back, as H5Zzstd is pretty orthogonal. |
|
I see, I just looked at the source code, but this is already planning for HDF5@0.18 https://github.com/JuliaIO/HDF5.jl/blob/master/filters/H5Zzstd/Project.toml |
|
Then feel free to exclude H5Zzstd from the Downgrade tests. |
|
Only thing is that HDZzstd@0.1.2 requires HDF5@0.17 minimum. That’s why downgrade fails right now. |
|
Fine, then let's lower the version bound for H5Zzstd. |
No description provided.