Skip to content

Ensure length of flattened_data is same as end of cumulative_length#211

Merged
gipert merged 2 commits intolegend-exp:mainfrom
iguinn:main
Jan 30, 2026
Merged

Ensure length of flattened_data is same as end of cumulative_length#211
gipert merged 2 commits intolegend-exp:mainfrom
iguinn:main

Conversation

@iguinn
Copy link
Copy Markdown
Contributor

@iguinn iguinn commented Jan 29, 2026

  • Fixed bug where _set_vector_unsafe was unsafely failing to resize the array
  • Emit a warning in the constructor if the flattened data has a different size than it should, and then resize it to match cumulative_length
  • Added a test

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.82%. Comparing base (f6fb8ef) to head (31e1886).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   80.81%   80.82%           
=======================================
  Files          47       47           
  Lines        3978     3980    +2     
=======================================
+ Hits         3215     3217    +2     
  Misses        763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gipert gipert merged commit 58ee2c5 into legend-exp:main Jan 30, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants