Enable __getitem__ in LGDOCollections classes to use slicing, masking, and fancy-indexing#212
Merged
gipert merged 18 commits intolegend-exp:mainfrom Feb 19, 2026
Merged
Enable __getitem__ in LGDOCollections classes to use slicing, masking, and fancy-indexing#212gipert merged 18 commits intolegend-exp:mainfrom
gipert merged 18 commits intolegend-exp:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 85.00% 85.12% +0.11%
==========================================
Files 19 19
Lines 1581 1600 +19
==========================================
+ Hits 1344 1362 +18
- Misses 237 238 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Closed
Member
|
Closing since we are about to merge #201 and this PR should be moved to legend-lh5io. |
Member
|
Actually let's keep this open since you also have LGDO-related changes. |
Contributor
Author
|
Moved all changes to iterator to lh5io; see legend-exp/legend-lh5io#9 |
iguinn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #69
Implemented sliced/masked/fancy indexed reading of Table, VectorOfVectors and Struct (it was already implemented for Array). Note that these implementations return LGDO objects of the same types rather than numpy arrays. The behavior of Array was not changed (see discussion in the above issue).