Feature/new release small gicp AND CLEAN UP :)#16
Merged
Conversation
moved external project to build folder, following gtsam_catkin
modified default anymal parameters by tuning on rosbags
Testing parameters
Improved build/install automation and minor cleanup
…otics/open3d_slam_private into feature/new_release_small_gicp
Fix/scan2scan
Collaborator
Author
|
Deleted:
|
Collaborator
Author
|
Deleted:
|
Collaborator
Author
|
Deleted:
|
Collaborator
Author
|
Ok I've cleaned up quite a bit: Added two tags so far (the PRs can also be tagged if rejected):
Here is summary of the remaining active branches:
For old feature branches which have significant code changes, there are now several PRs which changes that might or might not be beneficial to actually merge back into main (all are ROS1, instructions given per PR):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branches in Open3d_slam have gotten a bit messy, so i went and tested this branch on some ROS 1 datasets and it seems to run great.
Upon merging this back into
mainand make it the default ROS 1 commit for rsl_seam.I also want to do some cleanup after taking a long look at the current Network graph:
feature/new_release_small_gicp(this one)fix/scan2scanfix/queryfeature/improved_buildtesting_parametersdev/fasterhotfix/initializationfix/beni/initial_pose_in_degreesdev/benidev/glog_and_optovysotska.add_install_instructionsdev/fix_huge_bugarammis/devrelease/hike_stableandrelease/hike_20240624andfix/gravitywhich all point to the same commit with a "controversial gravity fix" (if you want to keep this branch, i would turn it into a tag instead)dev/mit,dev/tunnel,dev/turcan_researcher_01_02anddev/forest(which are all subsumed bydev/revision_submissionfeature/william_deskewdev/julian_replaydev/open_lab_daydev/gravis(just 2 commits)dev/open3d_slam_mirror(just 2 commits)step_by_stepdev/improvements_to_main(last commit was "Confused")aesch/localization_modeThe branches i would definitely leave are:
dev/yuni/f_rei(keep for now, a recent deployment branch)dev/jwolfram/social_nav(keep for now, a recent deployment branch)feature/b2w(the most up to date ROS 2 branch, actively developed)ros2jazzy(the branch for rsl_seam but I want to rename to ros2 and bring up to date withfeature/b2wASAP)The branches I am not sure about but would ideally like to delete or merge:
dev/grandtourcontains 13 commits ahead of master, and is only a few minor commits behind master, perhaps we can cherry pick commits from here after merging this branch into main?dev/revision_submissionhas 21 commits ahead of main but is quite far behind main and very far behind the current branch