Conversation
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
e3924b6 to
f6936af
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
6 times, most recently
from
79aa0bc to
5108c4b
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
5108c4b to
a5e3861
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
a5e3861 to
2dcf6e8
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
2dcf6e8 to
3a015bf
Compare
ralcolea
left a comment
ralcolea
left a comment
There was a problem hiding this comment.
I shared some comments, despite this PR is outdated.
Please, rebase this branch on top of dev and give some feedback about its current status :)
| }); | ||
| const fs = require("fs"); | ||
| fs.writeFileSync("${{ github.workspace }}/clang-tidy-result.zip", Buffer.from(download.data)); | ||
| - name: Extract analysis results |
There was a problem hiding this comment.
Consider separating different steps with a blank line to improve readability.
| jobs: | ||
| clang-tidy-results: | ||
| # Trigger the job only if the previous (insecure) workflow completed successfully | ||
| if: ${{ github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success' }} |
There was a problem hiding this comment.
This workflow did not run as part of this PR. I was checking with some LLMs and it says that post-static-analysis workflow should be merged first to the default branch.
Can you confirm whether this is needed or the cause(s) preventing this workflow to run as part of this PR?
There was a problem hiding this comment.
I believe that's the case, yes.
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
4 times, most recently
from
37dd0f5 to
7e0e432
Compare
ralcolea
left a comment
ralcolea
left a comment
There was a problem hiding this comment.
Nice job @uristdwarf 👍
Please, remember to remove the test commit before merging :)
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
7e0e432 to
18512e7
Compare
There are two seperate actions: One for running clang-tidy with no secrets, and another with secrets. This ensures that if the former is compromised, the latter secrets should be safe. Signed-off-by: Urmas Rist <urmas@leil.io>
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
6 times, most recently
from
41aaf13 to
1f6fa61
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
3 times, most recently
from
ffa1edb to
72167a8
Compare
uristdwarf
force-pushed
the
github-action-clang-tidy
branch
from
72167a8 to
2e938d1
Compare
3 participants
There are two seperate actions: One for running clang-tidy with no secrets, and another with secrets. This ensures that if the former is compromised, the latter secrets should be safe.