Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new windows-no-installer preset configuration to CMakePresets.json to allow building the Windows client without the installer. Feedback indicates that the BUILD_WINCLIENT_INSTALLER variable is not currently defined in the project's CMake files and should be renamed to ENABLE_WINCLIENT_INSTALLER for consistency. Additionally, the build preset should be updated to inherit from the windows preset instead of default to maintain platform-specific configurations.
There was a problem hiding this comment.
Pull request overview
Adds a dedicated CMake preset to build the Windows client without the (intended) installer portion, aimed at streamlining Windows-client development workflows.
Changes:
- Added a new
windows-no-installerconfigure preset inheriting fromwindows. - Added matching
windows-no-installerbuild and workflow presets to run configure+build with that configuration.
rolysr
force-pushed
the
add-windows-no-installer-preset
branch
from
322b434 to
c7b17cd
Compare
This commit adds a new Windows client specific compilation preset that will be need for development process only of the Windows client without including the installer building part. Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
rolysr
force-pushed
the
add-windows-no-installer-preset
branch
from
c7b17cd to
50f5212
Compare
rolysr
requested review from
GigaCronos,
antuan96314,
dmga44,
lgsilva3087 and
ralcolea
lgsilva3087
approved these changes
Apr 7, 2026
ralcolea
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new Windows client specific compilation preset that will be need for development process only of the Windows client without including the installer building part.