ci: Fix Jenkins unable to delete root files from workspace

[uristdwarf]

A previous commit already attempted to solve this. However, if the pipeline was cancelled in the middle of a build (before it chown the directory), it would still leave the files owned partially by root, which would mean that Jenkins would not be able to clean the directory.

This fixes that by moving the chown into the post cleanup stage.

[gemini-code-assist]

Summary of Changes

Hello @uristdwarf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Jenkins CI pipeline by ensuring that workspace files are correctly owned by the Jenkins user, even if a build is prematurely cancelled. This prevents subsequent build failures related to file cleanup permissions, improving the overall reliability of the continuous integration process.

Highlights

• Jenkinsfile Cleanup: The sudo chown command, which changes file ownership to the Jenkins user, has been moved from the build step to a dedicated cleanup block within the Jenkins pipeline.
• Improved Robustness: This change addresses an issue where Jenkins could not clean up workspace directories if a pipeline was cancelled mid-build, leaving files partially owned by root. Moving the chown ensures proper ownership is restored even after cancellation.

Changelog

• Jenkinsfile
  • Removed the sudo chown command from the make install step.
  • Added a cleanup block to the pipeline stage, which executes sudo chown on the workspace directory.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a CI issue where Jenkins could not clean up the workspace due to root-owned files left behind by a cancelled build. The approach of moving the chown command into a post cleanup block is correct and robustly addresses the problem. I have one suggestion to refine the implementation by narrowing the scope of the chown command to only the affected directory, which reduces potential side effects.

[ralcolea]

LGTM!