Skip to content

remove exception#317

Closed
ItsRebaseTime wants to merge 1 commit intolemmingDev:masterfrom
ItsRebaseTime:remove_exceptions
Closed

remove exception#317
ItsRebaseTime wants to merge 1 commit intolemmingDev:masterfrom
ItsRebaseTime:remove_exceptions

Conversation

@ItsRebaseTime
Copy link

Modify specialButtonBitPosition to handle out of range index without throwing an exception.
(it is the only exception in the project, removing it would increase compatibility with other projects where due to a memory or performance restrictions exceptions can not be used)

Modify specialButtonBitPosition to handle out of range index without throwing an exception.
@ItsRebaseTime ItsRebaseTime closed this by deleting the head repository Mar 11, 2026
@lemmingDev
Copy link
Owner

Hi

Should this still be merged?

@ItsRebaseTime
Copy link
Author

Hi,
I moved my project on https://github.com/Mystfit/ESP32-BLE-CompositeHID and proposed my changes over there.
Yet I would suggest adding these changes since there is no reason to have a single exception in the whole project.

@ItsRebaseTime
Copy link
Author

Also thanks for your work ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants