Merged
Conversation
This method must generate inner element if wrapper is lazy. This is done in #element by calling #lazy_generation
It now returns an empty array.
#do_parse and #do_parse_explicit are marked as private API.
Choice now implements a full #parse! method. It also implements #do_parse and #der_to_value. This is done to make #parse! only pase tag and length, and let element parse itself its content through #der_to_value. Thus, parsing advances on DER string, and no more call #parse! recursively on the same DER string (which raised a stack error).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choice is now recursive when using a Wrapper: