Add additional failing to_h sequence_of test#46
Closed
adfoster-r7 wants to merge 5 commits intolemontree55:masterfrom
Closed
Add additional failing to_h sequence_of test#46adfoster-r7 wants to merge 5 commits intolemontree55:masterfrom
adfoster-r7 wants to merge 5 commits intolemontree55:masterfrom
Conversation
`model` helper defines a name for an embedded model, but that name was not used. Now, this model is identified using this name in outer model. This avoid clash when embedding a same model more than once.
Choice content in resultant hash is no more the value of the chosen item, but a hash which key is the item name associated with item value.
adfoster-r7
commented
Jan 5, 2025
| ), | ||
| ldap_dn(:matched_dn), | ||
| ldap_string(:diagnostic_message), | ||
| wrapper(model(:referral, Referral), implicit: 3, optional: true) |
Contributor
Author
There was a problem hiding this comment.
This gets serialized incorrectly as:
"": ["ldap://example.com/ou=People,dc=example,dc=com"],
adfoster-r7
commented
Jan 5, 2025
spec/ldap_spec.rb
Outdated
| message_id: 2, | ||
| protocol_op: { | ||
| # TODO: Wrong | ||
| "": ["ldap://example.com/ou=People,dc=example,dc=com"], |
Contributor
Author
There was a problem hiding this comment.
Expected:
Suggested change
| "": ["ldap://example.com/ou=People,dc=example,dc=com"], | |
| "referral": ["ldap://example.com/ou=People,dc=example,dc=com"], |
In #private_to_h, do not take root element when my_element is a Model, but transform the model itsel to a Hash. Then, replace upper key in Hash by model name in current model.
e1c249b to
fca70f4
Compare
Contributor
Author
|
Issue in the PR description is fixed by #44 - will close 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is a separate bug to: #45 - so I thought I'd create a separate example test failure snippet. Let me know if I should close this off or raise a separate issue 💯
Current
to_houtput:Expected - Key not blank:
Wireshark example: