fix(noi-ask): Resolve XSS vulnerability in YuanbaoAsk#399
Open
Mirza-Samad-Ahmed-Baig wants to merge 1 commit intolencx:mainfrom
Open
fix(noi-ask): Resolve XSS vulnerability in YuanbaoAsk#399Mirza-Samad-Ahmed-Baig wants to merge 1 commit intolencx:mainfrom
Mirza-Samad-Ahmed-Baig wants to merge 1 commit intolencx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact: This is a DOM-based Cross-Site Scripting (XSS) vulnerability. If a malicious message is passed to the YuanbaoAsk.sync method, it could be executed in the user's browser, potentially leading to session hijacking or other malicious activities.
Solution: This pull request resolves the vulnerability by replacing the use of innerHTML with textContent. This ensures that any input is treated as plain text and not as executable code.