Modify function to init SERCOM and SPI settings#3
Open
EduardoGMohedano wants to merge 2 commits intolenvm:masterfrom
Open
Modify function to init SERCOM and SPI settings#3EduardoGMohedano wants to merge 2 commits intolenvm:masterfrom
EduardoGMohedano wants to merge 2 commits intolenvm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having three different functions to init SERCOM ports, I created just one function which needs as parameters the SERCOM port (required) and SPI settings cpol and cpha (which are optional) but if you want, you can configure them by passsing 0 or 1 values which can be passed using macros such as SPI_CPOL_HIGH or SPI_CPOL_LOW to be more readable.
I modifed example SERCOM0 and it works as expected.