feat: update wrap functionality#104
Open
dmitry-prohorov wants to merge 5 commits intoleoforfree:masterfrom
Open
feat: update wrap functionality#104dmitry-prohorov wants to merge 5 commits intoleoforfree:masterfrom
dmitry-prohorov wants to merge 5 commits intoleoforfree:masterfrom
Conversation
In latest node versions fs.write(fd, string[, position[, encoding]], callback) The callback parameter is no longer optional. Not passing it will throw a TypeError at runtime.
fix(promt): fix issues with fs.write
Wrap only separate lines with 100 character limit
Member
leonardoanalista
left a comment
leonardoanalista
left a comment
There was a problem hiding this comment.
awesome! lgtm, we merge when test passes. Please commit as a fix too. 👏 👏 👏
|
|
||
| const addBreaklinesIfNeeded = (value, breaklineChar = defaultBreaklineChar) => | ||
| value | ||
| const addBreaklinesIfNeededAndWrap = (value = '', config) => { |
Member
There was a problem hiding this comment.
that sounds perfect to me! thanks for the fix!
Author
|
@leonardoanalista done |
leonardoanalista
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this amazing tool!
When I try to use this tool and describe my body with
breaklineCharfeature I've faced trouble. You are wrapping the entire body into 100 characters lines and after that add break lines. So if I type1. update description|2. add commit message format section|3. add docker section|4. add commit helper tool sectioninto the body I will see next result (which is not expected)But I want to see