Skip to content

Corrected p-value comparison for null hypothesis rejection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adeva1
Copy link

@Adeva1 Adeva1 commented Jun 17, 2025

Corrected statement for non-normal distribution.

Summary by Sourcery

Correct p-value interpretation statements in the Shapiro-Wilk normality test notebook to ensure that small p-values lead to rejecting the null hypothesis and large p-values lead to accepting it.

Documentation:

  • Fix incorrect statement that a larger p-value implies rejecting the null hypothesis
  • Update phrasing to accept the null hypothesis when the p-value exceeds the significance level

Copy link

sourcery-ai bot commented Jun 17, 2025

Reviewer's Guide

Updated two markdown cells in the Shapiro-Wilk normality test notebook to correct p-value comparison language and refine hypothesis decision wording.

File-Level Changes

Change Details Files
Corrected p-value comparison for non-normal distribution rejection.
  • Replaced “much larger” with “much smaller” in the rejection statement
0020 Shapiro-Wilk test for Normality.ipynb
Refined null hypothesis decision wording.
  • Replaced “retain the null hypothesis” with “accept the null hypothesis” in the acceptance statement
0020 Shapiro-Wilk test for Normality.ipynb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Adeva1 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Adeva1
Copy link
Author

Adeva1 commented Jun 17, 2025

I meant to use the word - "reject" the null hypothesis "not accept" the null hypothesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant