Skip to content

Remove comments #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geethmaka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove comments #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5bab6e
Remove comments
geethmaka Oct 31, 2018
bcc2d1f
Update index.js
geethmaka Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions examples/cloud-data-storage-client-poc/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/**
Copy link
Collaborator

@dilantha111 dilantha111 Oct 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is useful. So better to keep that. line 1 to 3

* Before running this file make sure GOOGLE_APPLICATION_CREDENTIALS variable is set
*/


const Storage = require('@google-cloud/storage');
const gcs = new Storage();
Expand All @@ -11,7 +9,7 @@ gcs.interceptors.push({
'https://www.googleapis.com',
'http://localhost:8080'
);
// console.log(JSON.stringify(reqOpts));

return reqOpts;
},
});
Expand All @@ -24,10 +22,6 @@ gcs

const bucket = await gcs.bucket('test-bucket').get();

// this endpoint doesn't work correctly
// const uploadRes = await gcs.bucket('test-bucket').upload('./test.txt');

// await gcs.bucket('test-bucket').delete();
} catch (err) {
console.log(`${err.message}`);
}
Expand Down